Difference between revisions of "Set up the Goggle Monitor to work with it"
From Sonic Retro
Inferno Gear (talk | contribs) (Added a section to fix the infinite air glitch) |
Inferno Gear (talk | contribs) m (Made the new section more specific.) |
||
Line 147: | Line 147: | ||
== Fixing the infinite air glitch == | == Fixing the infinite air glitch == | ||
(Section by Inferno Gear, code by theocas.) | (Section by Inferno Gear, code by theocas.) | ||
− | Place | + | Place the following code at the end of Obj0D_Touch, but before locret_EBBA. |
<syntaxhighlight lang="asm"> ... | <syntaxhighlight lang="asm"> ... | ||
move.b #0,($FFFFFFA0).w ; move 0 to the goggle check | move.b #0,($FFFFFFA0).w ; move 0 to the goggle check |
Revision as of 16:08, 21 October 2017
Did you know that there are 2 unused monitors in Sonic 1? The 'S' and 'Goggle' monitors. You can place and also destroy them, but nothing will happen. In the split is under "Obj2E_ChkS:" the code for the S monitor, but there is no code for the Goggle monitor! If you want to have that monitor to do something, you need to set it up first. It's not too hard, so I will explain it you step-by-step. (Bug fix added by Inferno Gear.)
Quick guide
I know there are many people who just want to rip off the code without learning because they think they have better things to do. For those people I took the time to make a simple copy/paste guide:
Search for Obj2E_ChkS: and replace everything from there with this:
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
nop
Obj2E_ChkGoggles:
cmpi.b #8,d0 ; does monitor contain Goggles?
bne Obj2E_ChkEnd ; if not, branch to ChkEnd
nop
That was everything. If you are too dumb to add/understand this, then you weren't reading the real guide.
Full guide
This version tells you how to do this in detail, and very well explained. It's not more than what you can see in the quick version, but with comments and explanations you can learn something, so this one is recommended.
First off, open sonic1.asm and go to the Routine for the monitor contents (Obj2E). Scroll down until you see this:
...
Obj2E_RingSound:
move.w #$B5,d0
jmp (PlaySound).l ; play ring sound
; ===========================================================================
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkEnd
nop
Obj2E_ChkEnd:
rts ; 'S' and Goggles monitors do nothing
; ===========================================================================
Obj2E_Delete: ; XREF: Obj2E_Index
subq.w #1,$1E(a0)
bmi.w DeleteObject
rts
As you can see, there is no Goggle Code. But there is code that checks if the monitor contains 'S'. However, you can open SonED2 and add a new monitor using the object editor. Scroll through the different monitors, and you will see, in Obj2E are the monitors in the same order as in SonED2. The Goggle monitor is the last monitor in this list. This means that you will have to add your new code under the code for the S.
Before Obj2E_ChkEnd add a new label. The most fitting one is Obj2E_ChkGoggles: in my opinion:
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkEnd
nop
Obj2E_ChkGoggles:
Obj2E_ChkEnd:
rts ; 'S' and Goggles monitors do nothing
In ChkS is a code to branch to ChkEnd. Scroll up and you will see, there is in every monitor a code like this, but instead of branching to ChkEnd, they are branching to the next monitor code. So do the same with the S code. Change bne Obj2E_ChkEnd to bne Obj2E_ChkGoggles:
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
nop
Obj2E_ChkGoggles:
Obj2E_ChkEnd:
rts ; 'S' and Goggles monitors do nothing
Okay, we've set a few things up, but we are not done yet. Maybe you've noticed with the last step, those 2 lines in each monitor at the beginning (a 'cmpi.b' code and a 'bne' code). They are there to check if that monitor was destroyed and if so, do the code under it, otherwise check for the next monitor. We need that for the goggle monitor as well, so copy any of these 2 lines to your Obj2E_ChkGoggles: label. I'm using the lines of ChkS:
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
nop
Obj2E_ChkGoggles:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
Obj2E_ChkEnd:
rts ; 'S' and Goggles monitors do nothing
As you can see, this can't work, because they are checking for the same things! Look up again. Every monitor has a higher number in the cmpi.b command. The number in S was 7. So what is the next number? 8 of course! So change the 7 to 8 in your Goggle code:
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
nop
Obj2E_ChkGoggles:
cmpi.b #8,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
Obj2E_ChkEnd:
rts ; 'S' and Goggles monitors do nothing
7: We are nearly done. The last thing we have to do is to change the bne command in your Goggle code to ChkEnd. Like this:
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
nop
Obj2E_ChkGoggles:
cmpi.b #8,d0 ; does monitor contain 'S'
bne Obj2E_ChkEnd ; if not, branch to Goggle code
Obj2E_ChkEnd:
rts ; 'S' and Goggles monitors do nothing
Now we're done, and you can insert code to run when you destroy a Goggle monitor. But if you don't wanna add code for now, you have to add a nop under the bne command, otherwise you will get an Illegal zero length branch error when building. Also, you should change the comments, because they are really misleading. Here is my finished code:
Obj2E_ChkS:
cmpi.b #7,d0 ; does monitor contain 'S'
bne Obj2E_ChkGoggles ; if not, branch to Goggle code
nop
Obj2E_ChkGoggles:
cmpi.b #8,d0 ; does monitor contain Goggles?
bne Obj2E_ChkEnd ; if not, branch to ChkEnd
nop
Obj2E_ChkEnd:
rts
Example Code
Although that code is perfect now, it still does nothing. Unless you already have plans to do something with it, you can use this very simple code, that gives infinite air in LZ.
Go to the Goggle code and add a line, which is moving $1 to an unused RAM adress:
move.b #1,($FFFFFFA0).w ; move 1 to the goggle check
It should look like this:
...
nop
Obj2E_ChkGoggles:
cmpi.b #8,d0 ; does monitor contain Goggles?
bne Obj2E_ChkEnd ; if not, branch to ChkEnd
move.b #1,($FFFFFFA0).w ; move 1 to the goggle check
Obj2E_ChkEnd:
...
Next go to to Obj0A_ReduceAir: and add these 2 lines right after the label:
tst.b ($FFFFFFA0).w ; was a goggle monitor broken?
bne Obj0A_GoMakeItem ; if yes, branch
It should look like this:
Obj0A_ReduceAir:
tst.b ($FFFFFFA0).w ; was a goggle monitor broken?
bne Obj0A_GoMakeItem ; if yes, branch
...
Fixing the infinite air glitch
(Section by Inferno Gear, code by theocas.) Place the following code at the end of Obj0D_Touch, but before locret_EBBA.
...
move.b #0,($FFFFFFA0).w ; move 0 to the goggle check
...
That's the bug fixed! It's that simple. So, now the goggle check turns off at the end of a level.