Fix a remember sprite related bug
From Sonic Retro
(Original guide by MarkeyJester)
The object position loading routine (ObjPosLoad) loads a vertical strip of objects every 80 (hex) pixels, and as the screen scrolls along, the next 80 pixel strip is attended to. It runs through an object one at a time in this strip, checking and setting the remember flag values and loading the objects, until it's reached the end of the strip.
If however, the object RAM is full, the routine attempts to stop searching through the object list, however, it does not do this properly: When running right, it doesn't deset the remember flag and doesn't restore the remember counter; When running left, it doesn't deset the remember flag, full stop. This can lead to objects loading that are set as destroyed, or vise versa.
This issue generally never occurs in the original Sonic the Hedgehog title; Sonic Team were not reckless enough to fill an area in a level with too many objects. So, naturally, you won't see it much.
Preventing the problem
To fix the issue, go to "loc_DA10:", and after this line:
tst.b $04(a0) ; was this object a remember state? bpl.s loc_DA16 ; if not, branch subq.b #$01,(a2) ; move right counter back
This will ensure the remember counter for moving right is restored correctly if the SST was full.
Go to "loc_DA3C:", and find this:
Change "bset" to "btst".
Next, go to "OPL_MakeItem:", and after this line:
bset #$07,$02(a2,d2.w) ; set as removed
These changes will ensure that if the object couldn't load, it doesn't set the remember "removed" flag.
That'll solve the issue of rings, monitors, etc not remembering correctly under this circumstance. HOWEVER!! This will NOT fix the disappearing issue 100%. If there is no space in the object RAM, then objects will simply not load, the only way around that is to ensure that there are not so many objects placed within a single area. You must also keep in mind that certain objects create their own objects that also fill up the object RAM, such as the breakable wall in Green Hill Zone, which create multiple smaller object fragments.
|Fix a remember sprite related bug]]